fix functionality for RP2x hosts#3047
Merged
Merged
Conversation
brentru
approved these changes
Jun 2, 2025
Member
There was a problem hiding this comment.
@ladyada Looks good, I can see why you'd want to switch to a LED from NeoPixel for this board. May be useful in the future to expand the arch define for rp2040 to a more generalized define at the top of the sketch to include other boards that don't contain a status NeoPixel/DotStar.
Member
|
I don't have a Fruitjam so I am unable to test on hardware. You already tested on this h/w, so feel free to merge this PR at your convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested on fruit jam (ESP32-C6 client)